Add eslint to precious config and remove lint-js task
#682
+1,311
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autarch
force-pushed
the
modernize-linting-part-3
branch
2 times, most recently
from
05daba4
to
eb5b70a
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
86ce25c
to
4ae8974
Compare
autarch
force-pushed
the
modernize-linting-part-3
branch
from
eb5b70a
to
e84f5b6
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
4ae8974
to
71ff808
Compare
autarch
force-pushed
the
modernize-linting-part-3
branch
from
e84f5b6
to
dc4054e
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
71ff808
to
27ecacd
Compare
autarch
force-pushed
the
modernize-linting-part-3
branch
from
dc4054e
to
ffe8a79
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
2 times, most recently
from
eb1a043
to
a27ba96
Compare
autarch
force-pushed
the
modernize-linting-part-3
branch
from
ffe8a79
to
f50cd77
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
a27ba96
to
34fe136
Compare
|
If you disable showing whitespace in the files view it greatly reduces the size of the PR. |
autarch
changed the title
eslint to precious config and remove lint-js task
autarch
force-pushed
the
modernize-linting-part-3
branch
from
f50cd77
to
3cef66a
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
34fe136
to
4ffba20
Compare
autarch
force-pushed
the
modernize-linting-part-3
branch
from
3cef66a
to
7bc234b
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
4ffba20
to
8450565
Compare
autarch
force-pushed
the
modernize-linting-part-3
branch
from
7bc234b
to
a4fa093
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
8450565
to
bfb1618
Compare
|
Most of the JS file changes are whitespace-only, so the diff is much easier to review with those changes hidden. |
autarch
force-pushed
the
modernize-linting-part-4
branch
4 times, most recently
from
d9603d7
to
c5720d2
Compare
autarch
force-pushed
the
modernize-linting-part-4
branch
from
c5720d2
to
598852f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates our
eslintversion to 8.57.0, which is the most recent version that works with our YAML config file foreslint. Updating our config for the 9.x version didn't seem trivial.