Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy all Go code with golines #680

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Tidy all Go code with golines #680

merged 3 commits into from
Aug 6, 2024

Conversation

autarch
Copy link
Collaborator

@autarch autarch commented Jun 14, 2024

This also includes some Markdown tidying for files that changed in master after the previous PR was created. We really need a merge queue with tests for this project.

@autarch autarch force-pushed the modernize-linting-part-3 branch 3 times, most recently from 05daba4 to eb5b70a Compare June 14, 2024 04:57
@autarch autarch force-pushed the modernize-linting-part-3 branch 2 times, most recently from e84f5b6 to dc4054e Compare June 14, 2024 05:12
@autarch autarch force-pushed the modernize-linting-part-2 branch 5 times, most recently from a3c4aa9 to efe13c0 Compare June 25, 2024 13:22
@autarch autarch force-pushed the modernize-linting-part-2 branch 10 times, most recently from df326d0 to 0155250 Compare July 16, 2024 16:02
Base automatically changed from modernize-linting-part-2 to master August 2, 2024 14:28
@autarch
Copy link
Collaborator Author

autarch commented Aug 2, 2024

The only changes not from tidying with golines are changes in buildscript/sa.go to install golines, a change to our precious.toml config, and the Markdown tidying that would've been in the previous PR if we had a merge queue to tell me that the branch was out of date.

Copy link
Contributor

@tdq45gj tdq45gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I only skimmed through the code, assuming those are only format changes.

Copy link
Contributor

@edobranov edobranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@autarch autarch merged commit 685fd93 into master Aug 6, 2024
39 checks passed
@autarch autarch deleted the modernize-linting-part-3 branch August 6, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants