Add a new lint task to replace the lint-go task and use golangci-lint
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autarch
force-pushed
the
modernize-linting-part-2
branch
3 times, most recently
from
faa8751
to
7e561c5
Compare
autarch
force-pushed
the
modernize-linting-part-1
branch
from
e199b4f
to
f7ef820
Compare
autarch
force-pushed
the
modernize-linting-part-2
branch
from
9f8a935
to
19a80e1
Compare
autarch
force-pushed
the
modernize-linting-part-1
branch
from
f7ef820
to
9996125
Compare
autarch
force-pushed
the
modernize-linting-part-2
branch
from
19a80e1
to
3cbb3d4
Compare
autarch
changed the title
lint task to replace the lint-go task and use golangci-lint
autarch
force-pushed
the
modernize-linting-part-2
branch
5 times, most recently
from
a3c4aa9
to
efe13c0
Compare
autarch
force-pushed
the
modernize-linting-part-2
branch
10 times, most recently
from
8f7bb69
to
df326d0
Compare
autarch
force-pushed
the
modernize-linting-part-2
branch
from
df326d0
to
0155250
Compare
|
Since this is a big change, I will not merge this until after our next release. |
autarch
force-pushed
the
modernize-linting-part-2
branch
from
0155250
to
3a26d2e
Compare
This will eventually replace the existing `lint-go` and `lint-js` tasks
This includes fixes for a lot of linter issues. The vast majority of these were: * Unused functions, vars, and arguments * Missing error checking (I added a lot of `//nolint` comments where it was too painful to add actual checking). * Passing `nil` as a context * Using the deprecated `ioutil` package
There are a huge number of these because of the Go driver upgrade. There is a separate ticket, TOOLS-3633, for fixing these.
autarch
force-pushed
the
modernize-linting-part-2
branch
from
f6d7e35
to
dd36c5a
Compare
tdq45gj
reviewed
Jul 29, 2024
| // errors are received | ||
| func channelQuorumError(ch <-chan error, quorum int) (err error) { | ||
| // errors are received. | ||
| func channelQuorumError(ch <-chan error) (err error) { |
There was a problem hiding this comment.
Why does this function need to change?
There was a problem hiding this comment.
Every single caller set quorum to 2, so I just made this a const.
There was a problem hiding this comment.
It seems that the function's comment wasn't updated.
Co-authored-by: Jian Guan <61915096+tdq45gj@users.noreply.github.com>
Co-authored-by: Jian Guan <61915096+tdq45gj@users.noreply.github.com>
tdq45gj
approved these changes
Jul 30, 2024
| // errors are received | ||
| func channelQuorumError(ch <-chan error, quorum int) (err error) { | ||
| // errors are received. | ||
| func channelQuorumError(ch <-chan error) (err error) { |
There was a problem hiding this comment.
It seems that the function's comment wasn't updated.
autarch
requested review from
edobranov
and removed request for
suspicious-mango
edobranov
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Might've missed it, but are we using this anywhere? (if not, do we think we'll use it?)
There was a problem hiding this comment.
Oops, we will use it in a follow-up PR. Not sure how that snuck into this one, but I'll leave it since the next PR is just waiting on this one to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the ancient fork of
golintwe were using and replaces it withgolangci-lint, fixing quite a few linting issues found bygolangci-lint.It also removes the
format-gotask, as that can be done withpreciousandgolangci-lintas well.