Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owner key for morphTo relations #3162

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Owner key for morphTo relations #3162

merged 3 commits into from
Sep 30, 2024
+11 −2

Conversation

hans-thomas
Copy link
Contributor

Hi everyone, as mentioned #3093, the MorphTo relationship doesn't support the custom ownerKey on the eager loading.
This PR would fix this issue.

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file

@hans-thomas hans-thomas marked this pull request as ready for review September 27, 2024 10:31
@hans-thomas hans-thomas requested a review from a team as a code owner September 27, 2024 10:31
@alcaeus alcaeus requested review from GromNaN and removed request for jmikola September 30, 2024 08:07
GromNaN
GromNaN approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hans-thomas

@GromNaN GromNaN merged commit 7a865e7 into mongodb:5.x Sep 30, 2024
27 checks passed
@GromNaN GromNaN mentioned this pull request Sep 30, 2024
Closed
3 tasks
@hans-thomas hans-thomas deleted the ownerKey-for-morphTo branch October 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hans-thomas @GromNaN