Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-42155: adjust for updated source constants #3110

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Aug 22, 2024

https://jira.mongodb.org/browse/DOCSP-42155

SHORT = "Laravel Integration"
LONG = "Laravel MongoDB"

@github-actions github-actions bot added the docs label Aug 22, 2024
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + 1 suggestion

@@ -66,7 +66,7 @@ version and topology:
- MongoDB version 4.0 or later
- A replica set deployment or sharded cluster

MongoDB server and {+odm-short+} have the following limitations:
MongoDB server and the {+odm-short+} have the following limitations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MongoDB server and the {+odm-short+} have the following limitations:
MongoDB Server and the {+odm-short+} have the following limitations:

@rustagir rustagir marked this pull request as ready for review August 23, 2024 14:22
@rustagir rustagir requested a review from a team as a code owner August 23, 2024 14:22
@rustagir rustagir merged commit 80694e4 into mongodb:4.7 Aug 23, 2024
26 checks passed
This was referenced Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants