Upload code scanning results to correct ref when releasing #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
fix-sarif-release-upload
branch
from
6f89939
to
c8a44de
Compare
GromNaN
reviewed
Jun 17, 2024
| @@ -58,12 +63,21 @@ jobs: | |||
|
|
|||
| - name: Run PHPStan | |||
| run: ./vendor/bin/phpstan analyse --no-interaction --no-progress --ansi --error-format=sarif > phpstan.sarif | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
If there's an error, the file won't be generated and subsequent steps will crash, isn't it?
There was a problem hiding this comment.
It depends. IIRC, if PHPStan detects errors it will exit with a non-zero exit code but still write the file. Default behaviour in GHA would be to stop the job, but we want to at least continue to the next step to upload a SARIF file if it exists. If PHPStan crashed and didn't produce a file, I'm fine with the upload-sarif step failing as well.
alcaeus
force-pushed
the
fix-sarif-release-upload
branch
from
c8a44de
to
40839b4
Compare
alcaeus
force-pushed
the
fix-sarif-release-upload
branch
from
40839b4
to
0468f55
Compare
|
Note: fixed a wrong filename due to copy/paste. The PHPStan workflow should now pass again. |
GromNaN
approved these changes
Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as with mongodb/mongo-php-library#1346.
When running the static analysis workflow from the release workflow, the
github.refandgithub.shapoint to the release branch instead of the release tag. We have to account for this when uploading the sarif. Usinginputs.refworks, but thesarif-uploadaction also expects ashainput whenrefis given. To account for this, we get the ref forHEADonworkflow_dispatchevents so the code scanning results are correctly attached to the release tag.