Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(worker-runtime): remove worker proxy MONGOSH-1416 #2049

Merged
merged 31 commits into from
Sep 2, 2024
Merged

chore(worker-runtime): remove worker proxy MONGOSH-1416 #2049

merged 31 commits into from
Sep 2, 2024

Conversation

mabaasit
Copy link
Contributor

@mabaasit mabaasit commented Jul 1, 2024 •
edited by Anemy
Loading

@mabaasit mabaasit changed the title wip: chore(worker-runtime): remove worker proxy MONGOSH-1416 chore(worker-runtime): remove worker proxy MONGOSH-1416 Jul 2, 2024
@mabaasit mabaasit marked this pull request as ready for review July 2, 2024 13:43
@Anemy
Copy link
Member

Anemy commented Jul 26, 2024

Removed the child process usage. We now use the worker thread directly. Trying it out in Compass now. Let me know if this is what you had in mind @mabaasit @addaleax

@Anemy Anemy added the wip Work in Progress label Jul 26, 2024
addaleax
addaleax approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green 👍

@mabaasit mabaasit removed the wip Work in Progress label Aug 29, 2024
@mabaasit mabaasit merged commit 9b5c61a into main Sep 2, 2024
2 of 3 checks passed
@mabaasit mabaasit deleted the MONGOSH-1416-remove-process-indirection branch September 2, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy left review comments

@gribnoysup gribnoysup gribnoysup left review comments

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mabaasit @Anemy @addaleax @gribnoysup