⭐️ Azure: Microsoft Microsoft Defender for Cloud resource updates #4554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HRouhani
commented
Aug 14, 2024
•
HRouhani
commented
HRouhani
changed the title
tas50
changed the title
misterpantz
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Hi @HRouhani!
I went through the Microsoft documentation on each of these components and changed the product names and capitalization to match Microsoft's.
Some of Microsoft's choices are weird and don't seem consistent But 🤷 if you want to match Microsoft, you can accept these suggestions. Up to you!
providers/azure/resources/azure.lr
Outdated
| defenderForAppServices() dict | ||
| // Whether Microsoft Defender for SQL Servers on Machines is enabled | ||
| defenderForSqlServersOnMachines() dict | ||
| // Whether Microsoft Defender for Azure SQL Databases is enabled |
There was a problem hiding this comment.
Suggested change
| // Whether Microsoft Defender for Azure SQL Databases is enabled | |
| // Whether Microsoft Defender for Azure SQL is enabled |
There was a problem hiding this comment.
The focus is on " Azure SQL Databases" here
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
Co-authored-by: Letha <letha@mondoo.com>
chris-rock
force-pushed
the
hossein/azure-Defender
branch
from
7095054
to
7d39027
Compare
chris-rock
reviewed
Aug 15, 2024
| @@ -1697,9 +1697,25 @@ private azure.subscription.cloudDefenderService @defaults("defenderForServers de | |||
| subscriptionId string | |||
| // Whether the monitoring agent is automatically provisioned on new VMs | |||
| monitoringAgentAutoProvision() bool | |||
| // List of Defender for Server components and whether they are enabled | |||
| // List of Defender for Servers components and whether they are enabled | |||
There was a problem hiding this comment.
we cannot use boolean indicators for the text, when the output is non dict with multiple values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.