-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 improve user resource handling in Microsoft 365 #4518
Conversation
d886082
to
3baffb6
Compare
Test Results 28 files + 24 370 suites +167 1m 22s ⏱️ -16s Results for commit 7548494. ± Comparison against base commit 8bab9f0. This pull request removes 1 and adds 144 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
// index users by id | ||
idxUsersById map[string]*mqlMicrosoftUser | ||
// index users by principal name | ||
idxUsersByPrincipalName map[string]*mqlMicrosoftUser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it doesnt seem we use this index to fetch users, can we remove it if thats the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets remove it
- new init for `microsoft.user` - `micosoft.group.members` returns human users - `microsoft.application.owner` returns all application owner
Co-authored-by: Tim Smith <tsmith84@gmail.com>
Co-authored-by: Preslav Gerchev <preslav@mondoo.com>
1724041
to
7548494
Compare
This PR improves the
microsoft.user
resource.Simpler init functions
User can easily created by their object id and principal name now:
Retrieve owner for application registration
We added a new
owners
field tomicrosoft.application
which allows you to see all owners of your application:Group members
For groups, I it is essential to see all members. This can easily done now via: