Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 use protoc action consistently #4513

Merged
merged 1 commit into from
Aug 9, 2024
Merged

🧹 use protoc action consistently #4513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/pr-test-generated-files.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,14 @@ jobs:
echo "Install GCC on the runner.";
fi

# Note we do not use apt install -y protobuf-compiler` since it is too old
# Note we do not use apt install -y protobuf-compiler` since it is too old
- name: Install Protoc
uses: arduino/setup-protoc@v3
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the repo-token here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the action pulls the binaries from a github repo. protoc is only released on github


- name: Check generated files
run: |
PB_REL="https://github.com/protocolbuffers/protobuf/releases"
curl -LO $PB_REL/download/v${PROTO_VERSION}/protoc-${PROTO_VERSION}-linux-x86_64.zip
mkdir tools
unzip protoc-${PROTO_VERSION}-linux-x86_64.zip -d ./tools
rm protoc-${PROTO_VERSION}-linux-x86_64.zip
export PATH="$PATH:$(pwd)/tools/bin"
protoc --version
make prep
make cnquery/generate
Expand Down
Loading