Updates aws.account.id resource #4020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Ford <scott@scottford.io>
vjeffrey
reviewed
May 16, 2024
| @@ -16,7 +16,7 @@ import ( | |||
| ) | |||
|
|
|||
| func (a *mqlAwsAccount) id() (string, error) { | |||
| return "aws.account/" + a.Id.Data, nil | |||
There was a problem hiding this comment.
just a heads up, there are a couple other adjustments around discovery that we will need to do if this change goes in
There was a problem hiding this comment.
This change feels worth it IMO. The old output didn't really make sense. This output is better for asset inventory and customer usage. We should definitely understand the impact of this breaking change though anywhere else in the product.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
aws.account.idresource to only return the account ID. The previous version concatenates the string "aws.account/" to the account id. That string is redundant because the resource is alreadyaws.account.idOLD VERSION:
NEW VERSION: