Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add new fields to GH repos + handle null bools #3926

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tas50
Copy link
Member

@tas50 tas50 commented May 5, 2024

Add new fields + handle a few merge options that are bools with null values if not set

WIP as I'm digging into some odd behavior with some existing bools

Copy link
Contributor

github-actions bot commented May 5, 2024

Test Results

2 989 tests  ±0   2 988 ✅ ±0   1m 18s ⏱️ -9s
  329 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit 521ab86. ± Comparison against base commit e877e0f.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/2024-05-07_10:21:28.867063803_+0000_UTC_m=+0.007198754
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-07_10:21:28.867063803_+0000_UTC_m=+0.007198754
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-07_10:21:28.867063803_+0000_UTC_m=+0.007198754#01
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/2024-05-07_10:38:26.58070137_+0000_UTC_m=+0.010390488
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-07_10:38:26.58070137_+0000_UTC_m=+0.010390488
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-07_10:38:26.58070137_+0000_UTC_m=+0.010390488#01

♻️ This comment has been updated with latest results.

@imilchev imilchev marked this pull request as draft May 7, 2024 10:11
@imilchev
Copy link
Member

imilchev commented May 7, 2024

please undraft this once you think it is ready

Add new fields + handle a few merge options that are bools with null
values if not set

Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50 tas50 force-pushed the tas50/new_gh_repo_fields branch from 351f265 to 521ab86 Compare May 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants