Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add horizontal FOV converter #132

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

wertiop121
Copy link
Contributor

@wertiop121 wertiop121 commented Jul 24, 2024

Closes momentum-mod/game/issues/2126

Adds a text box to change the horizontal FOV, which gets automatically converted to/from FOV.
horiz_fov

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

POEditor JSON Strings (if needed)

[
	{
		"term": "Settings_Video_Horizontal_FOV",
		"definition": "Import Horizontal FOV"
	},
	{
		"term": "Settings_Video_Horizontal_FOV_Info",
		"definition": "Import horizontal FOV from Quake 3.\n\nHorizontal FOV is an accurate measure of field-of-view, which is dependent on aspect ratio. Source's FOV is always 4:3-based (equivalent to horizontal FOV in a 4:3 aspect ratio), and on higher aspect ratios the view is stretched to fill the whole screen."
	}
        
]

Copy link
Member

@PeenScreeker PeenScreeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Let a couple comments for minor changes I'd like to see. Nice work!

scripts/pages/settings/fov.js Outdated Show resolved Hide resolved
scripts/pages/settings/fov.js Outdated Show resolved Hide resolved
scripts/pages/settings/fov.js Show resolved Hide resolved
scripts/pages/settings/fov.js Show resolved Hide resolved
scripts/pages/settings/fov.js Outdated Show resolved Hide resolved
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I've imported into POEditor but I'd like to add that link to the source of the FOV back, see convo above.

Also @wertiop121 in the future please just amend/fixup changes into your original commit. I can squash this PR into one commit but for PRs that contain more than one meaningful commit, we'd need you to fixup properly. Please ask us if you need a hand with Git, we're happy to explain stuff.

@tsa96 tsa96 merged commit ff43cba into momentum-mod:master Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOV converter in settings
3 participants