Fix moment creation with object of strings #2721
Closed
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troyastorino
force-pushed
the
support-object-with-strings
branch
from
4a1665e
to
607a347
Compare
|
Looks good. Will merge in next release. |
|
Cool! |
|
Merged in 3945432 |
ichernev
added a commit
that referenced
this pull request
Dec 1, 2015
Fix moment creation with object of strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with parsing Aug 31st for objects with string values (see test for an example of the problem). Analogous behavior to problem in #1870 with arrays