Tc4 fix #1031
Merged
Tc4 fix #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch renames the tc4 test to activate it in the test suite. It also modifies the Makefile to build the input field test scripts. It also modifies the Python build scripts to be PEP8-conformant. We temporarily disable tc4 in the restart tests, since they currently fail. This needs to be addressed before we can merge this into the main branch. The patch does not enable the necessary Python modules for running on Travis, that will also be addressed later.
The custom TC4 Makefile has been added (oops), and the presumed Python Ubuntu packages have been added for Travis.
Gcc 7 4 0 patch
…o gcc_7_4_0_patch
Gcc 7 4 0 patch
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1031 +/- ##
=============================================
- Coverage 43.15% 26.19% -16.96%
=============================================
Files 212 212
Lines 62491 62486 -5
=============================================
- Hits 26968 16370 -10598
- Misses 35523 46116 +10593
Continue to review full report at Codecov.
|
|
Gaea regression test: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/9374 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (resubmitted) PR makes some changes to the tc4 test so that it now works within the Travis testing framework. It includes Python scripts for generating data, as well as a method for adding a Makefile to a local test for local customization.
This patch also includes several changes by @MJHarrison-GFDL which resolve an issue with sponges and restart file startup.
This PR is expected to fail its regression test, due to some bug fixes, but we do not expect any regressions on Gaea.