Gcc 7 4 0 patch #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tc4_fix #2 +/- ##
===========================================
- Coverage 44.69% 44.69% -0.01%
===========================================
Files 212 212
Lines 62244 62237 -7
===========================================
- Hits 27823 27815 -8
- Misses 34421 34422 +1
Continue to review full report at Codecov.
|
|
I just tested this on my laptop and the energies are identical, but I'm seeing differences in the other fields: Specifically the last three, Are you also seeing this, or is it just on my end? |
marshallward
added a commit
that referenced
this pull request
Jan 5, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Jan 7, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Jan 13, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Feb 17, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Feb 22, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Mar 9, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Mar 31, 2022
A fix to opening an existing file in MOM_file_parser was added. If an open file is re-opened, then the root PE will detect this and `return`, but the others will proceed into `populate_param_data` and get stuck in a broadcast waiting for root. We fix this by gathering the logical test result over PEs as a global any() function. Leading to change #2... `any_across_PEs` and `all_across_PEs` have been added to MOM_coms as any/all implementations over PEs (i.e. MPI ranks). Since legacy FMS does not support logical collectives, we convert to integers and use min/max collectives as an equivalent test.
marshallward
added a commit
that referenced
this pull request
Jan 4, 2023
Two changes, one an iterative improvement, the other a hack to get
things running.
1. The get_file_fields has been rewritten to fetch both axes and fields,
and there is some minimal effort to distinguish between them when
sweeping through variables. The results are then populated into the
linked lists of the handle.
Two caveats:
- it's untested, probably not even working
- we don't even use this function anymore, see change #2
2. get_file_info now just returns -1 for nvars.
Why? because previously FMS would initialize its nvar to -1, and if you
query a newly opened file then this is what you see. That was an
indicator to "recreate" the file (actually its metadata, which pulls
from existing templates and now matches the opened file).
To spoof this, I just always return -1 and trigger this "recreate"
effect. I can do this because the file metadata is static across runs.
Not robust, but it makes sense in a perverse way...
I will try to make this work honestly, so that get_file_fields will
return the correct content. But for now this feels sufficient.
marshallward
added a commit
that referenced
this pull request
Jan 11, 2023
Two changes, one an iterative improvement, the other a hack to get
things running.
1. The get_file_fields has been rewritten to fetch both axes and fields,
and there is some minimal effort to distinguish between them when
sweeping through variables. The results are then populated into the
linked lists of the handle.
Two caveats:
- it's untested, probably not even working
- we don't even use this function anymore, see change #2
2. get_file_info now just returns -1 for nvars.
Why? because previously FMS would initialize its nvar to -1, and if you
query a newly opened file then this is what you see. That was an
indicator to "recreate" the file (actually its metadata, which pulls
from existing templates and now matches the opened file).
To spoof this, I just always return -1 and trigger this "recreate"
effect. I can do this because the file metadata is static across runs.
Not robust, but it makes sense in a perverse way...
I will try to make this work honestly, so that get_file_fields will
return the correct content. But for now this feels sufficient.
marshallward
added a commit
that referenced
this pull request
Feb 22, 2023
Commit #1 --------- Removes calls to mpp_open, and replaces then with FATAL MOM_error calls when present. This also introduces the idea where only domain-decomposed files are used with infra IO. I've floated this idea a few times and people seem supportive, but it may not necessarily be embraced by everyone. Also moves Vertical_coordinate.nc from infra to native netCDF. This is primarily a trial balloon to see how the regression suite holds up. Commit #2 --------- mpp_open removal This formally removes the mpp_open functions, along with the FMS_writes control flag. Hopefully there is nothing much interesting here. Also removed open_file_unit since it's no longer used, and renamed open_file_type to open_file since the interface serves no purpose.
marshallward
added a commit
that referenced
this pull request
Feb 23, 2023
Commit #1 --------- Removes calls to mpp_open, and replaces then with FATAL MOM_error calls when present. This also introduces the idea where only domain-decomposed files are used with infra IO. I've floated this idea a few times and people seem supportive, but it may not necessarily be embraced by everyone. Also moves Vertical_coordinate.nc from infra to native netCDF. This is primarily a trial balloon to see how the regression suite holds up. Commit #2 --------- mpp_open removal This formally removes the mpp_open functions, along with the FMS_writes control flag. Hopefully there is nothing much interesting here. Also removed open_file_unit since it's no longer used, and renamed open_file_type to open_file since the interface serves no purpose.
marshallward
added a commit
that referenced
this pull request
Mar 3, 2023
Commit #1 --------- Removes calls to mpp_open, and replaces then with FATAL MOM_error calls when present. This also introduces the idea where only domain-decomposed files are used with infra IO. I've floated this idea a few times and people seem supportive, but it may not necessarily be embraced by everyone. Also moves Vertical_coordinate.nc from infra to native netCDF. This is primarily a trial balloon to see how the regression suite holds up. Commit #2 --------- mpp_open removal This formally removes the mpp_open functions, along with the FMS_writes control flag. Hopefully there is nothing much interesting here. Also removed open_file_unit since it's no longer used, and renamed open_file_type to open_file since the interface serves no purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.