-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete diagnostics are written to the available_diagnostics file #155
Comments
Oh, I've just read found_in_diagtable(), it seems that this problem of suggesting without registering is solved. |
OK, I was confused. There seems to be only one case where this is happening. Fixed in #147. |
Reopened just to keep track of everything that needs to make it into #147. |
adcroft
added a commit
that referenced
this issue
May 1, 2015
" This reverts commit 7f5cc91. - We are going to replace this commit with removing the conflicting line in MOM_obsolete_diagnostics.F90.
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this issue
Oct 9, 2017
- 08367b4 Merge branch 'nicjhan-diagnostic-tests' into dev/master - 958789e Removing latent_evap from list of obsolete diagnostics - b9a23f4 Revert "Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155" - 9d03ff3 Merge branch 'diagnostic-tests' of github.com:nicjhan/NOAA-GFDL-MOM6 into nicjhan-diagnostic-tests - ad474f4 Maximum number of diagnostics increased in order to do exhaustive diagnostic checking. mom-ocean#147. - 7f5cc91 Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155 - c464f2d Only register N2, S2 diagnostics when the configuration supports them. mom-ocean#147 - b1ae675 Bugfix: Fl_itidal diagnostic shape incorrect. Closes mom-ocean#151 - 568c54c Call diag_mediator_end to close open files. Closes mom-ocean#156
gustavo-marques
pushed a commit
to gustavo-marques/MOM6
that referenced
this issue
Jun 24, 2020
…s_jun2020 Improvements when applying lateral boundary diffusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Obsolete diagnostics get registered and hence turn up in the available_diagnostics file. Is there a particular reason why these are still being registered? Is it just so that the replacement diagnostic can be printed?
If so, I suggest we use FMS:get_diag_field_id() to check whether old diagnostics are in the diag_table. This way a replacement can be suggested without registering the diagnostic.
#147 depends on this, will probably fix it there.
The text was updated successfully, but these errors were encountered: