Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fl_itides diagnostic crashes the model #151

Closed
nichannah opened this issue Apr 28, 2015 · 2 comments
Closed

Fl_itides diagnostic crashes the model #151

nichannah opened this issue Apr 28, 2015 · 2 comments

Comments

@nichannah
Copy link
Collaborator

Inclusion of the Fl_itides diagnostic appears to crash the model, details below. If anyone has an idea please comment, otherwise I'll fix it as part of #147

*** Error in `../../build/gnu/ice_ocean_SIS2/debug/MOM6': double free or corruption (out): 0x000000000e10cda0 ***
Program received signal SIGABRT: Process abort signal.

With -fbounds-check:

At line 1389 of file ../../../../src/FMS/diag_manager/diag_manager.F90
Fortran runtime error: Array bound mismatch for dimension 1 of array 'rmask' (31/23)

In Valgrind:

==17085== Invalid write of size 4
==17085== at 0xE7503E: diag_manager_mod_MOD_send_data_3d (diag_manager.F90:1486)
==17085== by 0x7383B1: __mom_diag_mediator_MOD_post_data_3d_low (MOM_diag_mediator.F90:585)
==17085== by 0x7387F5: __mom_diag_mediator_MOD_post_data_3d (MOM_diag_mediator.F90:499)
==17085== by 0x5B1410: __mom_set_diffusivity_MOD_set_diffusivity (MOM_set_diffusivity.F90:793)
==17085== by 0x4A604B: __mom_diabatic_driver_MOD_diabatic (MOM_diabatic_driver.F90:475)
==17085== by 0x859B94: __mom_MOD_step_mom (MOM.F90:1228)
==17085== by 0x86F6E8: __ocean_model_mod_MOD_update_ocean_model (ocean_model_MOM.F90:406)
==17085== by 0x936E51: MAIN (coupler_main.F90:821)
==17085== by 0x943D4B: main (coupler_main.F90:130)
@nichannah
Copy link
Collaborator Author

I think this is just a bad allocation:

MOM_set_diffusivity.F90:448, nz should be nz+1 (?)

@adcroft
Copy link
Collaborator

adcroft commented Apr 28, 2015

Yes (to nz+1), based on the description and axis used in registration (axesTi) it looks like it is meant to be interface data. Not sure whose code this is to check with.

@adcroft adcroft closed this as completed in b1ae675 May 1, 2015
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@adcroft
MOM6: Merge branch 'nicjhan-diagnostic-tests' into dev/master
2e3e1d7 
- 08367b4 Merge branch 'nicjhan-diagnostic-tests' into dev/master
- 958789e Removing latent_evap from list of obsolete diagnostics
- b9a23f4 Revert "Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155"
- 9d03ff3 Merge branch 'diagnostic-tests' of github.com:nicjhan/NOAA-GFDL-MOM6 into nicjhan-diagnostic-tests
- ad474f4 Maximum number of diagnostics increased in order to do exhaustive diagnostic checking. mom-ocean#147.
- 7f5cc91 Update diagnostic name, old name has been obsoleted. Closes mom-ocean#155
- c464f2d Only register N2, S2 diagnostics when the configuration supports them. mom-ocean#147
- b1ae675 Bugfix: Fl_itidal diagnostic shape incorrect. Closes mom-ocean#151
- 568c54c Call diag_mediator_end to close open files. Closes mom-ocean#156
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this issue May 25, 2020
@alperaltuntas
Merge pull request mom-ocean#151 from gustavo-marques/merge-dev-maste…
fd68ffa 
…r-candidate-2020-05-15

Merge dev master candidate 2020 05 15
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Sep 9, 2020
Merged
angus-g pushed a commit to angus-g/MOM6 that referenced this issue Jul 8, 2022
@marshallward
Merge pull request mom-ocean#151 from Hallberg-NOAA/drag_as_body_force
5cadb72 
+Add option to apply bottom drag as a body force
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nichannah @adcroft