Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont overwrite tls_option #2148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tagg
Copy link

@tagg tagg commented Feb 9, 2024

Summary

tls_option(SSL_verifycn_name) is unconditionally overwritten.

Motivation

Mojo::UserAgent tls_option() is used to pass extra options to IO::Socket::SSL, but the code in Mojo::IOLoop::TLS unconditionally overwrites any SSL_verifycn_name the user is trying to pass.

References

As discussed on IRC.

I wanted to add a test case, but I cannot run the TEST_TLS tests. Being a very simple change, maybe a test is unneccessary.

@kraih
Copy link
Member

kraih commented Feb 9, 2024

I'm afraid without a test this probably won't be considered.

@kraih
Copy link
Member

kraih commented Feb 9, 2024

Don't think any TLS changes should be considered until our tests pass in github actions again. 5d83a17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants