Allow selection of an encoding on slurp/spew in Mojo::File #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraih
requested review from
a team,
marcusramberg,
kraih,
jhthorsen and
christopherraa
kraih
reviewed
Jul 29, 2023
kraih
reviewed
Jul 29, 2023
Grinnz
previously approved these changes
Jul 29, 2023
|
@Grinnz Correct. Since spurt can take an array of content, we can't easily check the last argument. Discussion was that spurt would likely be done away with in time |
kraih
reviewed
Jul 29, 2023
marcusramberg
approved these changes
Aug 14, 2023
jhthorsen
approved these changes
Aug 14, 2023
| } | ||
|
|
||
| sub spurt { | ||
| my ($self, $content) = (shift, join '', @_); | ||
| sub spew { |
|
This is great; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Alter Mojo::File to:
$file->slurp('UTF-8');etc.$file->spew('contents', 'UTF-8');etc.Motivation
As we discussed on IRC, allowing these options not only makes it easier for users as well as bring things more inline with what is allowed in the Mojo.js framework.