Avoid using $_ when loading the commands from namespaces

resolves #2175
mojolicious · May 17, 2024 · f6c8a1f · f6c8a1f
1 parent 431cc0a
commit f6c8a1f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/Mojolicious/Commands.pm b/lib/Mojolicious/Commands.pm
@@ -65,8 +65,10 @@ sub run {
   # Find all available commands
   my %all;
   for my $ns (@{$self->namespaces}) {
-    $all{substr $_, length "${ns}::"} //= $_->new->description
-      for grep { _command($_) } find_modules($ns), find_packages($ns);
+    for my $pkg (find_modules($ns), find_packages($ns)) {
+      next unless _command($pkg);
+      $all{substr $pkg, length "${ns}::"} //= $pkg->new->description
+    }
   }
 
   my @rows;