-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantics issue in 2.15.0 with 6.2.5.Final #929
Comments
I could not reproduce the issue. <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>default-group</groupId>
<artifactId>default-artifact</artifactId>
<version>1.0.0</version>
<packaging>pom</packaging>
<properties>
<artifact-version>6.2.5.Final</artifact-version>
</properties>
<dependencies>
<dependency>
<groupId>org.hibernate.validator</groupId>
<artifactId>hibernate-validator</artifactId>
<version>${artifact-version}</version>
</dependency>
</dependencies>
</project> mvn org.codehaus.mojo:versions-maven-plugin:2.15.0:update-properties -DallowMajorUpdates=false
Please attach debug log (add -X to the command) |
I'd have to find the time to create a minimal setup. The log I could create now would contain too much sensitive data. Not sure when I can find the time, thanks for checking. |
Okay, stole some time ... and it changes the character of the report, but might still be a bug!? pom.xml:
rules.xml
So there is an explicit rule for hibernate-validator ... and up to 2.14.2 there were no majorVersionUpdates suggested, but with 2.15.0 the update happens. |
Thanks, that's better. So, the crucial piece of information missing from the original report is the use of a ruleSet with comparisonMethod numeric. It's very likely that #898 introduced this regression. Until this is fixed, you might want to consider using a different comparisonMethod to your rule (e.g. "maven"), or restrict the version of the versions plugin. |
…s to produce the String representation of the version in their #toString method Otherwise numeric comparison will not work properly. Amended BoundArtifactVersion
…ions to produce the String representation of the version in their #toString method Otherwise numeric comparison will not work properly. Amended BoundArtifactVersion
The problem only occurs if one uses Hopefully the fix gets merged soon. |
…ions to produce the String representation of the version in their #toString method Otherwise numeric comparison will not work properly. Amended BoundArtifactVersion
…ions to produce the String representation of the version in their #toString method Otherwise numeric comparison will not work properly. Amended BoundArtifactVersion
…produce the String representation of the version in their #toString method Otherwise numeric comparison will not work properly. Amended BoundArtifactVersion
There seems to be a regression in 2.15.0 where update-properties updates the hibernate-validator version from 6.2.5.Final to 8.0.0.Final, even with allowMajorUpdates set to false. With 2.14.2 this does not happen.
The text was updated successfully, but these errors were encountered: