-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to target specifier supported by release flag in newer JDKs #326
Conversation
ups:
Looks like issue/bug in enforcer-maven-plugin |
I'm going push change to |
I guess there is only documentation purpose of With JDK 1.7 I'm getting:
anyway. |
No way for 1.7 |
<!-- as expected by Enforcer --> | ||
<minimalJavaBuildVersion>1.8</minimalJavaBuildVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It a little will complicate when project set target as 8 also want to check if used JDK is ok.
In such case we will must remember to set another property also.
My proposition is to postpone this, and allow 8 as 1.8 for maven enforcer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enforcer released and upgraded here, we can continue with it
I don't understand. My question is - what's the point of requiring Java Version with enforcer to be at least 1.8 when that condition can't be validated with earlier JDK? That's what bothers me: JDK at least 8 is (currently) enforced by the m-enforcer-p anyway in not very friendly manner, without the rule itself. |
Similar: Currently plugin minimum JDK is not verified ... it cause a error in runtime. Most of maven core plugins requires 1.8 today, Maven from 3.9 also will required 1.8 By the way, interesting discussion how to inform users of minimum JDK, when user try to execute Maven build with not supported JDK. |
This would allow to use
mojo.java.target
directly to configuremaven.compiler.release
.