Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable compilation on gcc 5.4 ubuntu #3

Closed
wants to merge 1 commit into from
Closed

Conversation

ekg
Copy link

@ekg ekg commented Aug 31, 2016

No description provided.

@mohaps
Copy link
Owner

mohaps commented Aug 31, 2016

@ekg - better still, make a Makefile. I was going to make one. But I think a Makefile for the sample is a better idea

@ekg
Copy link
Author

ekg commented Aug 31, 2016

Sure can do.

On Wed, Aug 31, 2016, 19:03 Saurav Mohapatra notifications@github.com
wrote:

@ekg https://github.com/ekg - better still, make a Makefile. I was
going to make one. But I think a Makefile for the sample is a better idea


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAI4EYeXvvvewDDRVand996A09Iakt7bks5qlcIFgaJpZM4JxyqJ
.

@breznak
Copy link
Contributor

breznak commented Oct 5, 2016

Thanks @ekg for the PR, not only needed for gcc 5.4, but for gcc 4.8, clang 3.7 etc too!
Fixes #6 for me 👍

@mohaps could you please merge this urgently?
(and leave a Makefile to a separate PR? Personally, I don't see a reason for a Makefile, as the project's aim seems to be "being a single simple header file", so it is intended to be included into existing projects only as a header and using theirs (c)make files)

@mohaps
Copy link
Owner

mohaps commented Oct 18, 2016

Closing this as I updated the readme and the pull request for std::list implementation added the include

@mohaps mohaps closed this Oct 18, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants