-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[driver] Add MAX31865 driver with STM32F469 Discovery example #993
Conversation
hshose
commented
Apr 6, 2023
•
edited
Loading
edited
- Driver
- Example with F469
- Works with Hardware
- README
da7f71b
to
e79d56f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice driver!
Please use tabs instead of spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver is (correctly) named max31865, but example max31855.
efeff65
to
b1105be
Compare
48f8bde
to
eaff392
Compare
Thanks @salkinium und @rleh for the review. Please don't merge yet - I havent tested the fixes with hardware yet. |
@hshose I pushed some commits to your branch, because it was too confusing to explain this in code comments. |
458444d
to
6110dca
Compare
If it's not too annoying, could you try out your changed on top of #1001 and check if these "weird" issues dissappear? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!