-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SAMx7x PWM driver #957
Merged
chris-durand
merged 3 commits into
modm-io:develop
from
chris-durand:feature/sam_x7x_pwm
Feb 7, 2023
Merged
Add SAMx7x PWM driver #957
chris-durand
merged 3 commits into
modm-io:develop
from
chris-durand:feature/sam_x7x_pwm
Feb 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48fb3c0
to
0bed0d0
Compare
salkinium
requested changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but I'm skeptical of the ChannelMode
API.
0bed0d0
to
b2c608a
Compare
@salkinium Are you ok with this now? HAL CI passed. Should I rebase? |
Yes and yes. And you can merge it directly. |
b2c608a
to
190bc78
Compare
salkinium
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add driver for SAMx7x PWM generator. This peripheral is independent of the Timer / Counter which can also generate PWM. It features 4 complementary output channels and advanced features like dead-time generation.
This driver does not yet implement support for external trigger inputs, fault inputs or DMA.
The driver is working.
Documentation is still missing.