Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAMx7x PWM driver #957

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Feb 6, 2023

Add driver for SAMx7x PWM generator. This peripheral is independent of the Timer / Counter which can also generate PWM. It features 4 complementary output channels and advanced features like dead-time generation.

This driver does not yet implement support for external trigger inputs, fault inputs or DMA.

  • Add driver
    • Add Doxygen docs to code
  • Example
  • Test

The driver is working. Documentation is still missing.

photo_2023-02-06_18-23-10

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but I'm skeptical of the ChannelMode API.

src/modm/platform/pwm/sam_x7x/pwm.cpp.in Outdated Show resolved Hide resolved
src/modm/platform/pwm/sam_x7x/pwm_base.hpp.in Show resolved Hide resolved
examples/samv71_xplained_ultra/pwm/main.cpp Show resolved Hide resolved
src/modm/platform/pwm/sam_x7x/pwm_base.hpp.in Show resolved Hide resolved
@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Feb 7, 2023
@chris-durand
Copy link
Member Author

@salkinium Are you ok with this now? HAL CI passed. Should I rebase?

@salkinium
Copy link
Member

salkinium commented Feb 7, 2023

Yes and yes. And you can merge it directly.

@chris-durand chris-durand merged commit 190bc78 into modm-io:develop Feb 7, 2023
@chris-durand chris-durand deleted the feature/sam_x7x_pwm branch February 7, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Development

Successfully merging this pull request may close these issues.

None yet

2 participants