Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for stm32-extended I²C driver #951

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Feb 1, 2023

  • Do not set bit I2C_CR1_NOSTRETCH which must not be set in master mode
  • Start next queued transaction after previous one has failed with NACK
  • Test on real hardware

From some L4 reference manual:
nostretch

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, moar fixes!

@salkinium salkinium added this to the 2023q1 milestone Feb 1, 2023
@salkinium
Copy link
Member

I'll wait with the merge until you've tested this in hardware.

The reference manual states:

This bit is used to disable clock stretching in slave mode.
It must be kept cleared in master mode.
@chris-durand
Copy link
Member Author

I have tested this with real hardware and it still works.

@chris-durand chris-durand merged commit c347f00 into modm-io:develop Feb 4, 2023
@chris-durand chris-durand deleted the fix/stm32-extended-i2c branch February 4, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants