Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAMx7x SPI driver #938

Merged
merged 5 commits into from
Jan 12, 2023
Merged

SAMx7x SPI driver #938

merged 5 commits into from
Jan 12, 2023

Conversation

chris-durand
Copy link
Member

@chris-durand chris-durand commented Jan 2, 2023 •
edited

  • Add SAMx7x SPI driver
  • Add SAMV71 SPI hardware unit test
  • Fix input type configuration for SAMx7x / SAMG5x when changing pin from pull-up to pull-down mode
  • Test in hardware with SAMV70N19 and MCP3008 SPI ADC.

The basic functionality of the driver has been verified with the hardware unit test. Also, the output waveforms look like SPI and have the right frequency.

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label Jan 2, 2023
@chris-durand chris-durand added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels Jan 2, 2023
salkinium
salkinium approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and good!

src/modm/platform/spi/sam_x7x/module.lb Outdated Show resolved Hide resolved
src/modm/platform/spi/sam_x7x/spi_hal.hpp.in Show resolved Hide resolved
src/modm/platform/spi/sam_x7x/spi_hal_impl.hpp.in Show resolved Hide resolved
@chris-durand
[sam] Add SAMx7x SPI driver
ad0752c
@chris-durand
[test] Add SAMV71 Xplained Ultra unit test config
0b1279f
@chris-durand
[test] Add SAMV71 SPI hardware unit test
57dbf52
@chris-durand
[test] Fix compilation of AD7280a test for SAM devices
29d8387 
The test defined struct Spi in the global scope which collides with a
name in the device header.
@chris-durand
[sam] Fix pull-down configuration for SAMx7x and SAMG5x devices
c93dd2c 
To enable the pull-down no pull-up may be active. The code for
reconfiguring the input type was not working when the type was changed
from pull-up to pull-down.
@chris-durand
Copy link
Member Author

Hardware testing with MCP3008 SPI peripheral was successful. @salkinium Merge?

@salkinium salkinium merged commit c93dd2c into modm-io:develop Jan 12, 2023
@chris-durand chris-durand deleted the feature/samx7x_spi branch January 12, 2023 20:03
@salkinium salkinium added this to the 2023q1 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧 testing 🧪
Milestone
2023q1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chris-durand @salkinium