Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adafruit Feather RP2040 board #898

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

cocasema
Copy link

No description provided.

@cocasema cocasema force-pushed the feature/feather-rp2040 branch 4 times, most recently from 4bc6aaa to cea4f47 Compare August 16, 2022 03:02
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

You can update the modm-devices submodule to your PRs commit sha and the CI should pick it up correctly. This works even before the PR is merged so that you can test all your changes together.
(You may need to add your fork as a remote to the ext/modm-devices git repo)

ext/rp/module.lb Outdated Show resolved Hide resolved
src/modm/platform/core/cortex/module.lb Outdated Show resolved Hide resolved
@cocasema cocasema force-pushed the feature/feather-rp2040 branch 2 times, most recently from 8c63a5d to 716e031 Compare August 16, 2022 20:57
@salkinium
Copy link
Member

I've manually added the flash section via the boot2_size option instead of patching the device file.
If you're happy with these changes, I'll squash the commits

@cocasema
Copy link
Author

Please go ahead, and thanks for the assistance!

@salkinium
Copy link
Member

I've set the author of your commits to your email, but it seems like you've registered a different email with GitHub so it's not correctly attributing you. Just FYI.

@salkinium salkinium added this to the 2022q3 milestone Aug 17, 2022
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Aug 17, 2022
@salkinium salkinium merged commit cceb801 into modm-io:develop Aug 17, 2022
@cocasema cocasema deleted the feature/feather-rp2040 branch August 17, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Development

Successfully merging this pull request may close these issues.

None yet

2 participants