-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2022q2 release #875
2022q2 release #875
Conversation
78c025a
to
3e3213d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
eec83e6
to
170c281
Compare
I'm not going to fix the gpio sampler issues for this release. |
I have added a fix for missing curly braces in
The last two lines will always be executed regardless of which clock the user is trying to disable. |
8f0fdaf
to
7aed364
Compare
I catched the Nucleo-F767 unit test with GDB in the undefined handler:
Any idea @chris-durand what might cause this fault on STM32F7? |
Might be memory-related. If I only include some tests (e.g. everything except |
|
That mock SPI device does dynamic allocation. We could have some bug there. |
The reason is memory corruption in the SPI mock. If you ran the hosted unit test binary in
The bug is most likely in the mock, not the driver code. |
This comment was marked as outdated.
This comment was marked as outdated.
One bug in the mock is fixed. |
We really need to build and run hosted unit tests with address sanitizer, thread sanitizer and UB sanitizer. I'll put that onto my todo list. |
a227a54
to
85f6a3b
Compare
85f6a3b
to
cfc3ea9
Compare
7256781
to
7cae883
Compare
If I understand correctly, this release is ready to be merged, right? |
Yes. Go! |
Just checking, cos my brain has teh dumbz today |
It's quarterly release time again! 2022-07-01 is the date.
Merge remaining PRs?Update toolchains to gcc 11Postponed to after releaseRebuild docker images and use new imagesNucleo-F446ZE(@rleh has no hardware)Failed 8 of 4985 tests
; gpio sampler...)Rcc::disable<...>()
always disabling unrelated clocks due to missing curly braces on a multi-lineif
block.operator delete[]
in SPI mock.data
and.stack
section at the same address.The fix from modm-io/avr-libstdcpp#20 seems to be required for the Mac OS 10.3 avr-gcc version. I have added an additional commit to it on a branch to also apply it for versions starting from gcc 10.3. Hardware testing is required that it does not break avr-gcc 11.1-11.2.