Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal to add SlaveModeTrigger::Internal0 on F4 #859

Merged
merged 1 commit into from
May 7, 2022
Merged

proposal to add SlaveModeTrigger::Internal0 on F4 #859

merged 1 commit into from
May 7, 2022

Conversation

lukh
Copy link
Contributor

@lukh lukh commented May 3, 2022

No description provided.

@salkinium salkinium added this to the 2022q2 milestone May 3, 2022
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label May 3, 2022
chris-durand
chris-durand approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The change looks good. From the STM32F4 reference manual:
trigger
The bits are the same for all timer instances that have an SMCR register.

salkinium
salkinium approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and reformulated the commit message.

@salkinium salkinium added ci:hal Triggers the exhaustive HAL compile CI jobs and removed ci:hal Triggers the exhaustive HAL compile CI jobs labels May 6, 2022
@salkinium salkinium merged commit c7bd876 into modm-io:develop May 7, 2022
@lukh lukh deleted the add_int_trig_f4_tim branch May 11, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@chris-durand chris-durand chris-durand approved these changes

@rleh rleh Awaiting requested review from rleh

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs enhancement 🌈
Milestone
2022q2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukh @salkinium @chris-durand