Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stm32] add Half Transfer handler for dma #858

Merged
merged 1 commit into from
May 4, 2022
Merged

[stm32] add Half Transfer handler for dma #858

merged 1 commit into from
May 4, 2022

Conversation

lukh
Copy link
Contributor

@lukh lukh commented May 3, 2022

I would love to add ISR handler for the Half Transfer Interrupt on DMA, for the stm32 serie
It looks like some of the STM32 are not passing UI

Don't know (yet) how to filter out the HT flag

@chris-durand chris-durand self-requested a review May 3, 2022 12:03
@chris-durand chris-durand added this to the 2022q2 milestone May 3, 2022
chris-durand
chris-durand reviewed May 3, 2022
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have quickly added the half transfer interrupt for all DMA types. Let's see what the CI says.

@chris-durand chris-durand added the ci:hal Triggers the exhaustive HAL compile CI jobs label May 3, 2022
chris-durand
chris-durand approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you rebase and squash the commits into one?

@lukh
Copy link
Contributor Author

lukh commented May 4, 2022

I am sorry, not used to this workflow, I need your help on this one...

@chris-durand
Copy link
Member

I am sorry, not used to this workflow, I need your help on this one...

I have done it.

@salkinium salkinium removed the ci:hal Triggers the exhaustive HAL compile CI jobs label May 4, 2022
@chris-durand chris-durand merged commit dab6c79 into modm-io:develop May 4, 2022
@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label May 4, 2022
@lukh lukh deleted the stm32_half_transfer_handler branch May 4, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-durand chris-durand chris-durand approved these changes

Assignees
No one assigned
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs feature 🚧
Milestone
2022q2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukh @chris-durand @salkinium