Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stm32] Uart: Add transmission complete flag #856

Merged
merged 1 commit into from
May 1, 2022

Conversation

strongly-typed
Copy link
Collaborator

Just a quick expose the TC flag in the API.

TXE goes high when the shift register started pouring the bytes to the line and a new byte can be written to the data register.
The TC flag goes high after the stop bit is send. Required for manually enabling and disabling line drivers.

@rleh rleh added this to the 2022q2 milestone May 1, 2022
@salkinium
Copy link
Member

Ohai, long time, no PR!
Do you want check if there is something similiar for AVR, just for consistency?

@strongly-typed
Copy link
Collaborator Author

Hoi, yes the first public PR for a long time. modm is in heavy use here in Switzerland!

e.g. ATMEGA32 UCSRA Bit 6 – TXC: USART Transmit Complete
I'll look into it but have no HW to test.

Shall it become part of the common API?

@salkinium
Copy link
Member

Shall it become part of the common API?

No, I just thought it would be neat to have feature parity while we're here. It's not a priority though.

@strongly-typed
Copy link
Collaborator Author

Just checked, there is e.g. no isTransmitRegisterEmpty in current modm's UART API as there is no UART HAL for AVRs (yet). So I would not add this unless we add the HAL concept to AVR. Agree?

@salkinium
Copy link
Member

Good point, I completely forgot about the AVR HAL…

@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label May 1, 2022
@salkinium salkinium merged commit 0e3d280 into modm-io:develop May 1, 2022
@strongly-typed strongly-typed deleted the feature/uart_tc branch May 1, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs enhancement 🌈
Development

Successfully merging this pull request may close these issues.

None yet

4 participants