Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ads101x #854

Merged
merged 2 commits into from
May 1, 2022
Merged

Feature/ads101x #854

merged 2 commits into from
May 1, 2022

Conversation

JKazem
Copy link
Contributor

@JKazem JKazem commented Apr 30, 2022

The example uses the same pins as on our custom board on which the driver has been tested. We are using the ads1014 so we have not been able to test the multiplexer functionality.

@chris-durand chris-durand self-requested a review April 30, 2022 14:48
@chris-durand
Copy link
Member

Just for your information, the failure of the Windows CI job is not due to your changes. It is not working right now.

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
(You need to sync the docs to make the CI happy)

src/modm/driver/adc/ads101x.hpp Outdated Show resolved Hide resolved
src/modm/driver/adc/ads101x.hpp Outdated Show resolved Hide resolved
@salkinium
Copy link
Member

Do you want to squash your fix into 723ce50 and rebase on top of latest develop?

Co-authored-by: Rasmus Kleist <kleist.rasmus@gmail.com>
Co-authored-by: Rasmus Kleist <kleist.rasmus@gmail.com>
@chris-durand chris-durand added this to the 2022q2 milestone May 1, 2022
@salkinium salkinium merged commit 596eafa into modm-io:develop May 1, 2022
@salkinium
Copy link
Member

Btw, thanks for contributing back, I see a lot of cool stuff in the DanSTAR repo, so I'm happy to see it appear here too ;-P

@twast92 twast92 deleted the feature/ads101x branch May 5, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants