Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAX31855 driver #850

Merged
merged 1 commit into from
Apr 22, 2022
Merged

MAX31855 driver #850

merged 1 commit into from
Apr 22, 2022

Conversation

rasmuskleist
Copy link
Contributor

The driver has been tested using a custom board with stm32g474ret6

@rleh rleh self-requested a review April 21, 2022 15:24
@rleh rleh added this to the 2022q2 milestone Apr 21, 2022
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

src/modm/driver/temperature/max31855.hpp Outdated Show resolved Hide resolved
@rleh
Copy link
Member

rleh commented Apr 21, 2022

The driver has been tested using a custom board with stm32g474ret6

Could you somehow create an example for (e.g.) the Nucleo-G474RE board, so that the CI at least compiles the code?

@rleh rleh changed the title Max38155 driver MAX31855 driver Apr 21, 2022
@rasmuskleist rasmuskleist force-pushed the feature-max31855 branch 2 times, most recently from 07cd45c to 934bc73 Compare April 21, 2022 16:26
@rasmuskleist
Copy link
Contributor Author

I have used the pins in the test that we have allocated on our board for the MAX31855

Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/modm/driver/temperature/max31855.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31855.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31855.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31855.hpp Outdated Show resolved Hide resolved
src/modm/driver/temperature/max31855.hpp Outdated Show resolved Hide resolved
examples/nucleo_g474re/max31855/main.cpp Outdated Show resolved Hide resolved
Copy link
Member

@chris-durand chris-durand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@salkinium salkinium requested a review from rleh April 21, 2022 19:05
@salkinium salkinium merged commit 2e34b11 into modm-io:develop Apr 22, 2022
@twast92 twast92 deleted the feature-max31855 branch May 5, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants