Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rp2040] Implement IRQ handlers for GPIO and QSPI #848

Merged
merged 1 commit into from
Apr 18, 2022
Merged

[rp2040] Implement IRQ handlers for GPIO and QSPI #848

merged 1 commit into from
Apr 18, 2022

Conversation

cocasema
Copy link

@cocasema cocasema commented Apr 16, 2022 •
edited

Based on discussion #847

@cocasema cocasema force-pushed the feature/rp2040-irq branch 3 times, most recently from 5746091 to 24c4f4f Compare April 16, 2022 07:21
salkinium
salkinium reviewed Apr 17, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I think we can merge the IntHandler template class into a normal class though.

src/modm/platform/extint/rp/module.lb Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/module.lb Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/module.md Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/int_handler.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/int_controller.hpp Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/module.md Outdated Show resolved Hide resolved
src/modm/platform/gpio/rp/base.hpp.in Show resolved Hide resolved
src/modm/platform/gpio/rp/base.hpp.in Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/module.lb Outdated Show resolved Hide resolved
examples/rp_pico/interrupt/main.cpp Outdated Show resolved Hide resolved
@cocasema cocasema force-pushed the feature/rp2040-irq branch 4 times, most recently from 28100f8 to 0a2e209 Compare April 18, 2022 01:04
salkinium
salkinium reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

Some very minor polish and this is ready to merge.

examples/rp_pico/interrupt/project.xml Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/module.md Outdated Show resolved Hide resolved
src/modm/platform/extint/rp/module.lb Outdated Show resolved Hide resolved
src/modm/platform/gpio/rp/module.lb Show resolved Hide resolved
src/modm/platform/extint/rp/module.md Show resolved Hide resolved
@cocasema cocasema force-pushed the feature/rp2040-irq branch 2 times, most recently from dc46141 to 33d09b9 Compare April 18, 2022 03:51
@cocasema
Copy link
Author

cocasema commented Apr 18, 2022 •
edited

Some very minor polish and this is ready to merge.

Please let me know if I missed something...

@salkinium
Copy link
Member

(Please rebase on latest develop)

@salkinium salkinium merged commit 599e0ba into modm-io:develop Apr 18, 2022
@salkinium salkinium added this to the 2022q2 milestone May 7, 2022
@cocasema cocasema deleted the feature/rp2040-irq branch August 24, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
example 🔑 feature 🚧
Milestone
2022q2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cocasema @salkinium