-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable flash driver for STM32G4 #838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi and welcome to modm!
Thanks for your pull request.
I have a few comments, see below.
Could you add an example for on of our STM32G4 dev boards (Nucleo-G431KB, Nucleo-G431RB, Nucleo-G474RE; if you have access to one of them?), so that the CI actually compiles the code? I suggest copying the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my Nucleo-G431KB:
Reboot␊
Erasing sectors [32, 64)␊
Erasing done in 704757us with errors: 0␊
Erasing with 95kiB/s␊
Programming done in 700045us with errors: 0␊
Programming with 95kiB/s␊
Works ✅
Thanks!
I have now triggered the extensive HAL tests. |
Feel free to do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sorry @rasmuskleist, but I am not able to push to the branch of this Pull Request, probably because the Could you tick the checkbox for me to push the squashed commits? |
b5d2933
to
f7dff92
Compare
It does not seem like I can let others work on the pull request unfortunately. Instead I added your repo as a remote and rebased my origin/feature-flash to rleh/feature-flash. I hope this is what your meant otherwise I would like to get some Git support. |
Perfekt, thanks! |
The flash implementation has been tested on STM32g474ret6. It does not implement bank selection for dual bank modes. Also it resolves and issue with g0 devices where the EOP flag should be cleared after programming.