Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rp2040] I2C implementation #830

Merged
merged 2 commits into from
Feb 28, 2022
Merged

[rp2040] I2C implementation #830

merged 2 commits into from
Feb 28, 2022

Conversation

andryblack
Copy link
Contributor

@andryblack andryblack commented Feb 15, 2022 •
edited
Loading

Synchronous implementation of I2C interface for RP2040

@rleh rleh self-requested a review February 21, 2022 04:03
rleh
rleh approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I added an example using the MCP79411 real time clock I had laying around on my desk, tested it on real hardware and also rebased onto develop.
Ready to merge from me!

@rleh rleh added the ci:hal Triggers the exhaustive HAL compile CI jobs label Feb 25, 2022
salkinium
salkinium approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@salkinium salkinium removed the ci:hal Triggers the exhaustive HAL compile CI jobs label Feb 28, 2022
@rleh rleh merged commit 21ba120 into modm-io:develop Feb 28, 2022
@rleh rleh added this to the 2022q1 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salkinium salkinium salkinium approved these changes

@rleh rleh rleh approved these changes

Assignees
No one assigned
Labels
feature 🚧
Milestone
2022q1
Development

Successfully merging this pull request may close these issues.
3 participants
@andryblack @salkinium @rleh