[board] Add configuration version for DISCO-F469NI #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleh
reviewed
Feb 5, 2022
salkinium
force-pushed
the
feature/config_revision
branch
2 times, most recently
from
0d06c65
to
5e41b53
Compare
salkinium
changed the title
salkinium
force-pushed
the
feature/config_revision
branch
from
5e41b53
to
35c02ed
Compare
rleh
reviewed
Feb 9, 2022
rleh
reviewed
Feb 9, 2022
salkinium
force-pushed
the
feature/config_revision
branch
2 times, most recently
from
581d47b
to
6ca4043
Compare
rleh
reviewed
Feb 11, 2022
salkinium
force-pushed
the
feature/config_revision
branch
from
6ca4043
to
b18385c
Compare
salkinium
commented
Feb 11, 2022
| @@ -14,6 +14,7 @@ | |||
| def init(module): | |||
| module.name = ":board:disco-f469ni" | |||
| module.description = FileReader("module.md") | |||
| # Revisions = [b-03, b-01] | |||
There was a problem hiding this comment.
The config is just a named (versioned) alias to a project.xml file inside modm. It must be declared in repo.lb so it can act as a repository option, therefore you need a mechanism to pass the revision to the repo.lb without having a giant table there, which is currently done by regexing the board/*/module.lb files. It's not great, but I don't know a better way. Ideas?
There was a problem hiding this comment.
Maybe create a module.revisions file and add one configuration name per line?
There was a problem hiding this comment.
Let's fix it when it becomes a problem. I first would like to see more board revision examples to decide a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds configuration versions for the DISCO-F469NI board
<extends>modm:disco-f469ni:b-03</extends>to fix the different I2C address of the touch sensor.See #818 (comment).
Fixes #818.
cc @rleh