-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RP2040 #806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, I love it!
(Copyright notice need to be updated in most files, either add yourself or replace the authors if the file is new)
You should also add the example to the CI under here: https://github.com/modm-io/modm/blob/develop/.github/workflows/linux.yml#L82 (I think the CI is failing because you force pushed the modm-devices commit away.) |
14a7dc6
to
0eebf74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work, I'm very impressed!
d9e53e7
to
e230f4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding fiber communications (channels, semaphores etc) there is some unfinished work in this commit, that still has bugs: https://github.com/salkinium/modm/tree/feature/fiber_waitable
97c008b
to
38cc993
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Great work as usual, very nice refactor of the fibers to support multicore! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chris-durand This is now ready to be rebased/merged, please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Thank you very much!
Thanks to @andryblack, this PR was a lot of fun to accompany! |
Docs are now online: https://docs.modm.io/develop/api/rp2040/modules.html |
Initial RP2040 support.
For now implemented basic functional of core, clock, gpio, uart, spi and usb modules.
Same examples buildable and worked on device.
Early implementation added to align structure and naming conventions.