-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[driver] IMU ADIS16470 #805
Conversation
c1a2d5a
to
216548d
Compare
216548d
to
5305edc
Compare
Maybe the MISO needs a pullup? |
I already enabled the STM32 internal pull-up, but maybe it is to weak for 600kHz SPI... |
For F4 it's only 30-50kOhm for the pullup (see datasheet, I/O characteristics). |
I added an external 3k9 pull-up to MISO and still same issue. |
EDIT: Ah, the calculation is wrong, I made a typo with the calculator but it's not the issue anyways 🤦♂️ . |
Uiuiui, the gloves are off now, at your pencils, ready, math! |
The data out should not require a pull-up. I would remove it. |
Works now with SPI mode 3 and without any pull-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice driver, just needs to guard the IO module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash?
Yes, but after investigating why the MSC_CTRL register does not read back correctly. |
c0adf49
to
b153186
Compare
Squashed, tested (again) on real hardware & ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Very nice!
Except reading back MSC_CTRL register, see [driver] IMU ADIS16470 #805 (review)Timing issue solved: MSC_CTRL register requires 3ms waiting before reading back.