-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[driver] Add AS5600 driver + generalize data-type for external encoders #1166
Conversation
56b690d
to
07b44f8
Compare
Done @salkinium
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs
984dc8f
to
e049ce7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, one more thing
Ready to merge I'd say... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank you!
Driver for a small and cheap magnetic encoder.
First, i've generalized the angle data type of existing magnetic encoder driver as5047.
👉 A consequent follow up would be to integrate
driver/encoder/angle.hpp
withmath/geometry/angle.hpp
. F.e. by adding conversion constructors tomath/geometry/angle.hpp
and drop the redundant methods ::toRadian() and ::toDegree() indriver/encoder/angle.hpp
. But we might also just keep it as it is.What do you think?