CMake: Fix generation with multiple repos #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
reviewed
Mar 8, 2024
| @@ -164,6 +162,8 @@ set({{ name | upper }}{{ "_" ~ (profile | upper) if profile | length else "" }} | |||
| endfunction() | |||
|
|
|||
| function(modm_targets_create project_name) | |||
| find_package (Python3 COMPONENTS Interpreter REQUIRED) | |||
There was a problem hiding this comment.
What's the difference? Does cmake have its own package manager???
There was a problem hiding this comment.
Not quite a package manager, just a set of modules to find dependecies.
find_program fails to find a valid Python executable on my Windows machine and reading the docs it seems to only search a predefined set of paths per platform for a name match.
find_package in this case will use the FindPython3 module shipped with CMake to find python so it should be more flexible and does find my Python install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the CMake generator work with projects using multiple repositories, similar to how it works with SCons.
Currently this would generate multiple targets called modm, causing an error.