Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board support for STM32F401 Discovery #1117

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

cajt
Copy link
Contributor

@cajt cajt commented Jan 4, 2024

Added a BSP for the F401 Discovery Board.

Notes:

  • Completed basic testing with the included examples, including the USART, Gyro and Accelerometer.
  • Board is obsolete according to ST.

@rleh
Copy link
Member

rleh commented Jan 4, 2024

The CI complains about two things:

  • Please add the new example folder to the appropriate CI job in .github/workflows/linux.yml.
  • Please run python3 tools/scripts/synchronize_docs.py to synchronize the documentation.

Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to take care of deduplicating the examples somehow, but that shouldn't stop this pull request.

examples/stm32f401_discovery/uart/main.cpp Outdated Show resolved Hide resolved
@cajt
Copy link
Contributor Author

cajt commented Jan 5, 2024

We really need to take care of deduplicating the examples somehow, but that shouldn't stop this pull request.

From the abstraction side, the boards looked almost identical and could run mostly unmodified code (only difference was number of LEDs and their names).

The way I used the examples was basically a unit test, to check is the BSP is working. For use as code examples the level of abstraction is fine imho, and kinda what I would expect. To ease dealing with testing, a more abstract and generalized way of writing these might help. Especially for more elaborate tests. But that things can't do double duty as example and unit-test anymore (if that was ever intended).

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I'll squash your commits and merge it later)

@salkinium salkinium merged commit 2381c61 into modm-io:develop Jan 5, 2024
13 checks passed
@salkinium salkinium added this to the 2024q1 milestone Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants