Add STM32G0B/C support #1036
Merged
Add STM32G0B/C support #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-durand
force-pushed
the
feature/stm32g0b_c
branch
from
1044ae1
to
dafb21e
Compare
chris-durand
commented
Jun 5, 2023
chris-durand
commented
Jun 5, 2023
chris-durand
commented
Jun 5, 2023
klsc-zeat
reviewed
Jun 6, 2023
The channel ids were incorrectly sorted as strings and then converted to int. The conversion must happen first for the correct ordering. The bug has no practical effect since no device has more than 8 channels.
chris-durand
force-pushed
the
feature/stm32g0b_c
branch
from
dd896df
to
43dcf5a
Compare
|
@klsc-zeat Do you require FDCAN support on STM32G0B/C? I have disabled the driver on those devices for now. |
Unfortunately yes but only FDCAN1. But i think i will manage that with the examples from the branch. I will post a PR but it will probably take me some time. |
klsc-zeat
approved these changes
Jun 7, 2023
FDCAN on STM32G0 is currently not supported due to the shared interrupt handler.
chris-durand
force-pushed
the
feature/stm32g0b_c
branch
from
43dcf5a
to
76d2d49
Compare
salkinium
approved these changes
Jun 7, 2023
chris-durand
added
ci:hal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FDCAN, unsupported and deactivated on G0B/C for nowNot tested yet.