-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stm32] Watchdog IWDG driver #1009
Conversation
7fb32d6
to
187ad38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice driver, thanks!
I have some comments/suggestions below:
b1b96b6
to
bcb2cf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ❤️
@rleh I am not really getting why the macos test is failing. |
There currently is an issue with the MacOS CI, has something to do with apple thinking it's a good idea to link We can just ignore it for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Ideally squash it into two commits, one for the peripheral and one for the example. (I can do it too if it's annoying for you.)
Co-authored-by: Victor Costa <victor.houriecosta@zuehlke.com>
Co-authored-by: Victor Costa <victor.houriecosta@zuehlke.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I squashed the commits and rebased, now the MacOS CI problem should pass.
Lets merge this pull request next :)
This is a proposal to add basic iwdg support to modm.