Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7309: Update versioneer with versioneer install --vendor #7311

Merged
merged 5 commits into from
Jun 12, 2024
Merged

FIX-#7309: Update versioneer with versioneer install --vendor #7311

merged 5 commits into from
Jun 12, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jun 12, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves versioneer.py is broken in python 3.12 #7309
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#7309: Update versioneer with 'versioneer install --…
50cab99 
…vendor'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
use 'black'
46220dd 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fixes
5381a52 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
update code style for 'versioneer.py'
8d79f81 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix
e76d84f 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 12, 2024
View reviewed changes
modin/_version.py Dismissed Show dismissed Hide dismissed
@anmyachev anmyachev marked this pull request as ready for review June 12, 2024 11:40
@YarShev YarShev merged commit 5c1c6a2 into modin-project:main Jun 12, 2024
37 checks passed
@anmyachev anmyachev deleted the issue7309 branch June 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

versioneer.py is broken in python 3.12
2 participants
@anmyachev @YarShev