Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7138: Stop reloading modules for custom docstrings. #7307

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

Signed-off-by: sfc-gh-mvashishtha mahesh.vashishtha@snowflake.com

What do these changes do?

Stop reloading modules for custom docstrings. See #7138 for motivation.

Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
Signed-off-by: sfc-gh-mvashishtha <mahesh.vashishtha@snowflake.com>
anmyachev
anmyachev previously approved these changes Jun 11, 2024
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

modin/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@noloerino noloerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Co-authored-by: Anatoly Myachev <anatoliimyachev@mail.com>
@anmyachev anmyachev merged commit 0a06455 into modin-project:main Jun 11, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants