Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST-#7316: Run a subset of CI tests with python 3.10 and 3.11 on a scheduled basis. #7289

Merged
merged 1 commit into from
Jun 17, 2024
Merged

TEST-#7316: Run a subset of CI tests with python 3.10 and 3.11 on a scheduled basis. #7289

merged 1 commit into from
Jun 17, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 27, 2024 •
edited
Loading

What do these changes do?

Python 3.11 has been tested separately in #7317. It works.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Run a subset of CI tests for all Python versions that Modin has declared supported on a scheduled basis. #7316
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@YarShev
Copy link
Collaborator

YarShev commented Jun 10, 2024

Can we now switch to testing with python 3.10?

@anmyachev
Copy link
Collaborator Author

Can we now switch to testing with python 3.10?

I don't think so, we can easily start using python functionality that isn't in 3.9 and break the code.

@YarShev
Copy link
Collaborator

YarShev commented Jun 13, 2024

Maybe we should add weekly testing on python 3.10 to catch such breaking changes so as to be prepared for transition to python 3.10?

@anmyachev anmyachev force-pushed the py3.10 branch 4 times, most recently from 1e5416e to 7f22fd3 Compare June 16, 2024 14:36
@anmyachev anmyachev changed the title TEST-#0000: Try to run CI with python 3.10 TEST-#7316: Run a subset of CI tests with python 3.10 and 3.11 on a scheduled basis. Jun 16, 2024
anmyachev
anmyachev commented Jun 16, 2024
View reviewed changes
.github/actions/python-only/action.yml
default: "3.9.x"
default: "3.9"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does the same thing - installs the latest version of python. Reworked according to the prevailing style.

@anmyachev
TEST-modin-project#7316: Run a subset of CI tests with python 3.10 an…
3b223bb 
…d 3.11 on a scheduled basis.

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review June 16, 2024 15:04
YarShev
YarShev reviewed Jun 17, 2024
View reviewed changes
.github/workflows/ci.yml
@@ -17,6 +17,9 @@ on:
- setup.py
- versioneer.py
push:
schedule:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this run only on push to main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. The load on CI resources will be greater. If necessary, in the future we can simply increase the launch frequency (not once a week, but twice, for example).

@YarShev
Copy link
Collaborator

YarShev commented Jun 17, 2024

Why only a subset of CI tests? Which tests are missing?

@anmyachev
Copy link
Collaborator Author

Why only a subset of CI tests? Which tests are missing?

For example, test-fuzzydata.

@YarShev YarShev merged commit d54f927 into modin-project:main Jun 17, 2024
38 checks passed
@anmyachev anmyachev deleted the py3.10 branch June 17, 2024 11:14
arunjose696 pushed a commit to arunjose696/modin that referenced this pull request Jul 11, 2024
@anmyachev @arunjose696
TEST-modin-project#7316: Run a subset of CI tests with python 3.10 an…
ab2f263 
…d 3.11 on a scheduled basis (modin-project#7289)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
arunjose696 pushed a commit to arunjose696/modin that referenced this pull request Jul 11, 2024
@anmyachev @arunjose696
TEST-modin-project#7316: Run a subset of CI tests with python 3.10 an…
1192c35 
…d 3.11 on a scheduled basis (modin-project#7289)

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run a subset of CI tests for all Python versions that Modin has declared supported on a scheduled basis.
2 participants
@anmyachev @YarShev