Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7240: Allow doc_checker.py works with functools.cached_property #7241

Merged
merged 2 commits into from
May 8, 2024
Merged

FIX-#7240: Allow doc_checker.py works with functools.cached_property #7241

merged 2 commits into from
May 8, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 7, 2024 •
edited
Loading

What do these changes do?

PR also updates numpydoc: 1.1.0 -> 1.6.0.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Allow doc_checker.py works with functools.cached_property #7240
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#7240: Allow 'doc_checker.py' works with 'functools.…
c55855a 
…cached_property'

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev force-pushed the issue7240 branch 5 times, most recently from a2f6e05 to 3eca901 Compare May 7, 2024 15:58
@anmyachev
fix
2b6848f 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review May 7, 2024 16:05
anmyachev
anmyachev commented May 7, 2024
View reviewed changes
scripts/doc_checker.py
@@ -32,8 +32,8 @@
import types
from typing import List

from numpydoc.docscrape import NumpyDocString
from numpydoc.validate import Docstring
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring object does not exist in version 1.6.0.

@anmyachev anmyachev mentioned this pull request May 7, 2024
Merged
7 tasks
@YarShev YarShev merged commit df81f3a into modin-project:main May 8, 2024
37 checks passed
@anmyachev anmyachev deleted the issue7240 branch May 8, 2024 11:36
@korbit-ai korbit-ai bot mentioned this pull request Aug 13, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@korbit-ai korbit-ai bot mentioned this pull request Aug 15, 2024
Closed
7 tasks
@local-dev-korbit-ai-mentor local-dev-korbit-ai-mentor bot mentioned this pull request Aug 15, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow doc_checker.py works with functools.cached_property
2 participants
@anmyachev @YarShev